piomin/claude-ai-spring-boot

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

- 3 description: Comprehensive code review for Java - clean code principles, API contracts, null safety, exception handling, and performance. Use when user says "review code", "refactor", "check API", or before merging changes.
+ 3 description: Review checklist for Java / Spring Boot code - correctness, security, performance, Spring signals, REST semantics, and code smells; project rules are referenced from conventions, not repeated. Use when user says "review code", "check this PR", "refactor", "check API", or before merging changes.
- 8 Systematic code review combining clean code principles, API design, and Java best practices.
+ 8 Knowledge for reviewing Java / Spring Boot changes: **what to flag** and how to recognize it. The review process, scope, and report format belong to the `code-reviewer` agent; project rules belong to the `conventions` skill.
+ 9 
+ 10 **No duplication:** this skill holds only what no other skill states (generic Java quality, smells, REST semantics, detection signals). Project rules live in `conventions`, `spring-boot`, and `jpa-patterns`; the references here point to them and never restate them, so a rule change is made in one place.
- 14 - Before merging PR or releasing API changes
+ 16 - Before merging a PR or releasing API changes
- 16 ## Review Strategy
+ 18 ## What to Load
- 18 1. **Quick scan** - Understand intent, identify scope
- 19 2. **Checklist pass** - Apply relevant categories below
- 20 3. **Summary** - List findings by severity (Critical → Minor → Good)
+ 20 Read only the references that match the changed files.
- 22 ---
+ 22 | If the change contains | Read |
+ 23 |------------------------|------|
+ 24 | Any Java code | `references/correctness.md`, `references/spring-conventions.md` (signals; rules in `conventions`) |
+ 25 | Controllers, DTOs, OpenAPI, error handling | `references/api-contract.md` |
+ 26 | Input handling, auth, config, secrets, actuator | `references/security.md` |
+ 27 | Repositories, queries, entity loops | `references/performance.md` |
+ 28 | Entities, `*.sql` migrations, `spring.jpa.*`, Flyway | `conventions` → Relational Database Schema (Flyway); `spring-boot` → `references/data.md` |
+ 29 | Any non-trivial logic | `references/smells.md` |
- 24 ## Clean Code Principles
+ 31 Related skills, loaded only when the diff needs them:
- 26 ### DRY - Don't Repeat Yourself
+ 33 | Topic | Skill |
+ 34 |-------|-------|
+ 35 | Project rules (No Lombok, RestClient, Flyway, Problem Details) | `conventions` |
+ 36 | Lazy loading, fetching, optimistic locking | `jpa-patterns` |
+ 37 | Test quality, `RestTestClient`, Testcontainers | `testing-patterns` |
+ 38 | Log levels, MDC, structured logging | `logging-patterns` |
+ 39 | UI contract details | `spring-boot` → `references/ui-contract.md` |
+ 40 | Records, sealed types, pattern matching | `java-modern` |
- 28 **Violation:**
- 29 ```java
- 30 // ❌ Duplicated validation logic
- 31 public void createUser(UserRequest req) {
- 32     if (req.getEmail() == null || !req.getEmail().contains("@")) {
- 33         throw new ValidationException("Invalid email");
- 34     }
- 35 }
+ 42 ## Severity
- 37 public void updateUser(UserRequest req) {
- 38     if (req.getEmail() == null || !req.getEmail().contains("@")) {
- 39         throw new ValidationException("Invalid email");
- 40     }
- 41 }
- 42 ```
+ 44 - **Critical** - security, data loss, crash risk → must fix before merge
+ 45 - **Important** - correctness, performance, maintainability → should fix
+ 46 - **Code Smell** - style, complexity, minor issues → nice to have (always phrased as a heuristic, see `references/smells.md`)
+ 47 - **Good** - positive feedback worth reinforcing
- 44 **Fix:**
- 45 ```java
- 46 // ✅ Single source of truth
- 47 public class EmailValidator {
- 48     public void validate(String email) {
- 49         if (email == null || !email.contains("@")) {
- 50             throw new ValidationException("Invalid email");
- 51         }
- 52     }
- 53 }
- 54 ```
+ 49 ## Non-Goals
- 56 ### KISS - Keep It Simple
+ 51 - Formatting, import order, naming style that a formatter or linter enforces
+ 52 - Personal taste or rewrites that do not fix a concrete problem
+ 53 - Rules the repo contradicts on purpose: when `CLAUDE.md`, `conventions`, or an existing documented decision overrides a rule here, the repo wins
- 58 **Violation:**
- 59 ```java
- 60 // ❌ Over-engineered
- 61 public interface UserFactory {
- 62     User createUser();
- 63 }
- 64 public class ConcreteUserFactory implements UserFactory {
- 65     public User createUser() { return new User(); }
- 66 }
- 67 ```
+ 55 ## Quick Reference
- 69 **Fix:**
- 70 ```java
- 71 // ✅ Simple
- 72 public User createUser() { return new User(); }
- 73 ```
- 74 
- 75 ### YAGNI - You Aren't Gonna Need It
- 76 
- 77 **Violation:**
- 78 ```java
- 79 // ❌ Premature abstraction
- 80 public class ConfigurableUserServiceFactoryProvider { }
- 81 ```
- 82 
- 83 **Fix:**
- 84 ```java
- 85 // ✅ Implement when actually needed
- 86 public class UserService { }
- 87 ```
- 88 
- 89 ---
- 90 
- 91 ## API Contract Review
- 92 
- 93 ### HTTP Verb Semantics
- 94 
- 95 | Verb | Use For | Idempotent | Safe |
- 96 |------|---------|------------|------|
- 97 | GET | Retrieve resource | Yes | Yes |
- 98 | POST | Create new resource | No | No |
- 99 | PUT | Replace entire resource | Yes | No |
- 100 | PATCH | Partial update | No* | No |
- 101 | DELETE | Remove resource | Yes | No |
- 102 
- 103 **Common Mistakes:**
- 104 ```java
- 105 // ❌ POST for retrieval
- 106 @PostMapping("/users/search")
- 107 public List<User> search(@RequestBody SearchCriteria criteria) { }
- 108 

This preview is limited. See the complete change on GitHub.

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Network or broad shell → After Network or broad shell

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Network or broad shell

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Network or broad shell → After Network or broad shell

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Network or broad shell

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub

Before Instructions only → After Instructions only

77966b6804a2 → 8d0eeefe2cd5

Compare on GitHub

Before Not checked yet → After Instructions only

First observation → 77966b6804a2

No earlier version was observed for comparison.

Compare on GitHub